turcsanyip commented on a change in pull request #4781:
URL: https://github.com/apache/nifi/pull/4781#discussion_r564566112
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/test/java/org/apache/nifi/util/db/TestJdbcCommon.java
##########
@@ -679,11 +680,12 @@ public void
testConvertToAvroStreamForDateTimeAsLogicalType() throws SQLExceptio
testConvertToAvroStreamForDateTime(options,
(record, date) -> {
+ java.sql.Date expected =
DataTypeUtils.convertDateToUTC(date);
final int daysSinceEpoch = (int) record.get("date");
final long millisSinceEpoch =
TimeUnit.MILLISECONDS.convert(daysSinceEpoch, TimeUnit.DAYS);
- java.sql.Date actual =
java.sql.Date.valueOf(Instant.ofEpochMilli(millisSinceEpoch).atZone(ZoneOffset.UTC).toLocalDate());
- LOGGER.debug("comparing dates, expecting '{}', actual
'{}'", date, actual);
- assertEquals(date, actual);
+ java.sql.Date actual = new java.sql.Date(millisSinceEpoch);
+ LOGGER.debug("comparing dates, expecting '{}', actual
'{}'", expected, actual);
+ assertEquals(expected, actual);
Review comment:
I could not go on that way because
`testConvertToAvroStreamForDateTime()` is used in two places and the other
really expects a Date object.
However, I found a simpler way to convert the Date to the expected number of
days, and then to assert the raw value from Avro against that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
