lordgamez commented on pull request #981:
URL: https://github.com/apache/nifi-minifi-cpp/pull/981#issuecomment-768961678


   > Currently all expression language-related tests (unit and integration) are 
disabled in Windows builds in the cmake file:
   > 
   > 
https://github.com/apache/nifi-minifi-cpp/blob/f2fd698504c0cba9e024d4a3a5868a374ba18b5e/extensions/expression-language/tests/CMakeLists.txt#L24
   > 
   > 
https://github.com/apache/nifi-minifi-cpp/blob/f2fd698504c0cba9e024d4a3a5868a374ba18b5e/extensions/expression-language/tests/CMakeLists.txt#L50
   > 
   > so this change will have no effect.
   
   Thanks for the heads up! After compiling and running it locally it seems 
that there are multiple problems with the tests on Windows from different 
rounding of values to missing resources, which need to be fixed before it can 
be re-enabled. I'll update the Jira issue and close this PR, we can return to 
this issue later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to