lordgamez commented on a change in pull request #979:
URL: https://github.com/apache/nifi-minifi-cpp/pull/979#discussion_r566307587
##########
File path: NOTICE
##########
@@ -55,6 +58,7 @@ This software includes third party software subject to the
following copyrights:
- libsodium - Copyright (c) 2013 - 2018 Frank Denis under the ISC software
license
- IANA timezone database - public domain
- date (HowardHinnant/date) - notices below
+- JSON for Modern C++ (nlohmann/json) - Copyright (c) 2013-2021 Niels Lohmann
Review comment:
In the latest version it has become a new dependency for azure sdk and
does not compile without it. We may investigate if it's viable to patch and
replace it with rapidjson in the sdk, although it may be cumbersome to maintain
it in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
