dam4rus opened a new pull request #984:
URL: https://github.com/apache/nifi-minifi-cpp/pull/984
Apparently this PR raises some questions about how to properly fix this.
Some of the classes are actually never instantiated on the stack. So the
move constructors are actually never called. All of the classes with deleted
copy and move constructors in the PR are such classes. I think it's safer to
delete the special functions for such classes instead of them doing something
wrong if somehow they are called.
Other classes, like Peer, had only a move constructor which would lead to
strange behaviors. A user-defined move constructor deletes the copy
constructor, however they had defaulted copy and move assignment operators. So
they could have been copied with assignment but not through constructor. I
don't believe this was intentional?
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI
results for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
