mtien-apache opened a new pull request #4801: URL: https://github.com/apache/nifi/pull/4801
…ly-generate certificates, Keystores, and Truststores and return it wrapped in a TLS configuration. Updated TestInvokeHTTP, TestInvokeHttpSSL, TestInvokeHttpTwoWaySSL, and TestListenHTTP to use new Keystore functionality. Uncommented code to enable a password-protected truststore in TestInvokeHttpSSL. Added unit tests. NIFI-1355-rebase Fixed a contrib check error. NIFI-1355-rebase2 Removed unnecessary Truststore only method. Cleaned up code. NIFI-1355-rebase2 Fixed a delete Path method causing a build failure. Update nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java Co-authored-by: exceptionfactory <[email protected]> Update nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java Co-authored-by: exceptionfactory <[email protected]> Update nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java Co-authored-by: exceptionfactory <[email protected]> Update nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestInvokeHttpTwoWaySSL.java Co-authored-by: exceptionfactory <[email protected]> NIFI-1355-rebase2 Revised based on PR feedback. Added a password requirement when creating a new truststore. Handled exception when loading a passwordless truststore type of Bouncy Castle PKCS12. NIFI-1355-rebase2 Revised based on PR feedback. Added the exception's full stacktrace to a delete method for easier troubleshooting. Reverted unnecessary re-ordering of class imports. Replaced a TLS config setting to use the getProtocol() method. Fixed the usage of a qualified name for java.nio.file.Files by refactoring a deprecated method in TestListenHTTP. Refactored some code. NIFI-1355-rebase3 - Created a new branch and updated InvokeHttp Tests due to recent changes from NIFI-8171. Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: #### Description of PR _Created a new PR due to significant test changes from NIFI-8171. Updated the InvokeHttp Tests with my changes._ In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [x] Have you written or updated unit tests to verify your changes? - [ ] Have you verified that the full build is successful on JDK 8? - [x] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
