szaszm commented on a change in pull request #975:
URL: https://github.com/apache/nifi-minifi-cpp/pull/975#discussion_r568574449
##########
File path: extensions/aws/processors/DeleteS3Object.cpp
##########
@@ -30,6 +30,11 @@ namespace minifi {
namespace aws {
namespace processors {
+const core::Property DeleteS3Object::ObjectKey(
+ core::PropertyBuilder::createProperty("Object Key")
+ ->withDescription("The key of the S3 object. If none is given the filename
attribute will be used by default.")
+ ->supportsExpressionLanguage(true)
+ ->build());
Review comment:
I didn't realize it was an attribute, sorry.
##########
File path: extensions/aws/s3/S3ClientRequestSender.h
##########
@@ -0,0 +1,47 @@
+/**
+ * @file S3Wrapper.h
+ * S3Wrapper class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#pragma once
+
+#include "S3RequestSender.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace aws {
+namespace s3 {
+
+class S3ClientRequestSender : public S3RequestSender {
+ public:
+ minifi::utils::optional<Aws::S3::Model::PutObjectResult>
sendPutObjectRequest(const Aws::S3::Model::PutObjectRequest& request) override;
+ bool sendDeleteObjectRequest(const Aws::S3::Model::DeleteObjectRequest&
request) override;
+ minifi::utils::optional<Aws::S3::Model::GetObjectResult>
sendGetObjectRequest(const Aws::S3::Model::GetObjectRequest& request) override;
+ minifi::utils::optional<Aws::S3::Model::ListObjectsV2Result>
sendListObjectsRequest(const Aws::S3::Model::ListObjectsV2Request& request)
override;
+ minifi::utils::optional<Aws::S3::Model::ListObjectVersionsResult>
sendListVersionsRequest(const Aws::S3::Model::ListObjectVersionsRequest&
request) override;
+ minifi::utils::optional<Aws::S3::Model::GetObjectTaggingResult>
sendGetObjectTaggingRequest(const Aws::S3::Model::GetObjectTaggingRequest&
request) override;
+ minifi::utils::optional<Aws::S3::Model::HeadObjectResult>
sendHeadObjectRequest(const Aws::S3::Model::HeadObjectRequest& request)
override;
+};
Review comment:
Async operations generally scale better, that's why I was raising this.
The functionality and use cases are the same, but it would probably result in
1-2 orders of magnitude better performance. Now we have to wait for a request
to finish before we can proceed. We could pipeline multiple requests with an
async API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
