markap14 commented on pull request #4798: URL: https://github.com/apache/nifi/pull/4798#issuecomment-772652269
@tpalfy the code here looks good. I'll be testing some corner cases today to see if i can cause any errors. One thing that I noticed, though, is that there is nothing added to the User Guide for this feature. Probably makes sense to update the User Guide to note that the feature exists, and to explain some of the caveats. For example, if I run in a cluster and I have a processor configured to run on Primary Node only and I click Run Once, it runs only on the Primary Node, not all nodes. If Execution is set to All Nodes, it is triggered once on every node. It's worth clarifying that in the docs. Also, if the processor's outbound connection has backpressure applied, I am able to click Run Once, but it doesn't actually get triggered. Similarly, if there is an incoming connection and the connection is empty, it doesn't get triggered. These are good things and I believe the correct/desired behavior. But I think it's important to explicitly call these things out in the User Guide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
