thenatog commented on pull request #4804: URL: https://github.com/apache/nifi/pull/4804#issuecomment-772741138
I've set the default to True and realized the documentation for standard processors is compiled from PropertyDescriptor descriptions which I had already added. I think that allowing users to explicitly set protocols may be too library specific. "H2_PRIOR_KNOWLEDGE" for example sounds like it is specifically for use with the okhttp client library for certain use cases, and is not necessarily broadly applicable to HTTP generally. I may be wrong. My approach would be to go with this simpler approach for now, and if we find that users want more specific control then we can move to that. The issue again being that they would be specifying names of protocols that are derived from okhttp which may not exist in a different HTTP client library. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
