lordgamez commented on a change in pull request #993:
URL: https://github.com/apache/nifi-minifi-cpp/pull/993#discussion_r571089642
##########
File path: libminifi/test/bustache-tests/CMakeLists.txt
##########
@@ -33,7 +33,6 @@ FOREACH(testfile ${BUSTACHE_INTEGRATION_TESTS})
createTests("${testfilename}")
target_link_libraries(${testfilename} ${CATCH_MAIN_LIB})
target_link_libraries(${testfilename} ${Boost_IOSTREAMS_LIBRARY})
- target_link_libraries(${testfilename} bustache)
Review comment:
We never needed this actually. We add minifi-bustache-extensions library
as a whole archive which links the locally built BUSTACHE::libbustache bundled
library. This line would additionally try to link the bustache library
installed on the system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
