GitHub user ktseytlin opened a pull request:
https://github.com/apache/nifi/pull/1112
NIFI-2799: AWS Credentials for Assume Role Need Proxy
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
https://issues.apache.org/jira/browse/NIFI-2799
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
Full tests have been run, and unit tests for additional functionality pass.
This build has also been tested on AWS and it is confirmed that the way the
proxy is configured using these changes allow for the AssumeRole tokens to be
properly generated.
- [X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
@jvwing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ktseytlin/nifi NIFI-2799
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1112
----
commit e20bb67d94f2bc636ffed6c205a2cebfad5ddab6
Author: Keren Tseytlin <[email protected]>
Date: 2016-10-06T20:44:51Z
Merge pull request #1 from apache/master
Bringing in Nifi master into local
commit 8c6d0c81a2ff5e417ee7b676a0db5d773a6c7679
Author: Keren Tseytlin <[email protected]>
Date: 2016-10-06T21:04:12Z
Updated AssumeAWSCredentials to allow for Assume Role to create and use
proxy credentials in order to get temprorary access keys when traversing VPCs
commit a980194e9b3ceca0cc8fdd2ad17b996c4c1d19b7
Author: speddy93 <[email protected]>
Date: 2016-10-06T21:10:41Z
Added tests: testAssumeRoleInvalidProxyPort
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
