hunyadi-dev commented on a change in pull request #1013:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1013#discussion_r580366848
##########
File path: libminifi/src/core/Processor.cpp
##########
@@ -223,7 +223,18 @@ bool Processor::flowFilesQueued() {
return false;
}
-bool Processor::flowFilesOutGoingFull() {
+uint64_t Processor::numIncomingFlowFilesQueued() const {
+ std::lock_guard<std::mutex> lock{mutex_};
+
+ uint64_t sum = 0;
+ for (const auto& connectable : _incomingConnections) {
+ auto connection = std::static_pointer_cast<Connection>(connectable);
Review comment:
Does this assume that on a connectable, every incoming connection is
actually a `Connection`? If so, why not change the type of the
`_incomingConnections` to a `std::set<std::shared_ptr<Connection>>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
