ChrisSamo632 commented on a change in pull request #4828:
URL: https://github.com/apache/nifi/pull/4828#discussion_r580565064
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/csv/TestCSVHeaderSchemaStrategy.java
##########
@@ -66,9 +66,37 @@ public void testSimple() throws SchemaNotFoundException,
IOException {
.allMatch(field ->
field.getDataType().equals(RecordFieldType.STRING.getDataType())));
}
Review comment:
The "Use String Fields From Header" Schema Access Strategy is
parser-agnostic (as far as I can tell) in the CSVReader service, however the
implementation is hard-coded to use the Apache Commons CSV Parser (I've not
changed that).
That parser sets up its own CSV Format using the same (updated) CSVUtils
methods, so it should take into account the settings changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]