thenatog commented on a change in pull request #4836:
URL: https://github.com/apache/nifi/pull/4836#discussion_r582175528
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/flow/TestPopularVoteFlowElection.java
##########
@@ -157,7 +158,7 @@ public void testEmptyFlowIgnoredIfNonEmptyFlowExists()
throws IOException {
@Test
public void testAutoGeneratedVsPopulatedFlowElection() throws IOException {
final ExtensionManager extensionManager = new
StandardExtensionDiscoveringManager();
- final FingerprintFactory fingerprintFactory = new
FingerprintFactory(createEncryptorFromProperties(getNiFiProperties()),
extensionManager);
+ final FingerprintFactory fingerprintFactory = new
FingerprintFactory(createEncryptorFromProperties(getNiFiProperties()),
extensionManager, SecureHasherFactory.getSecureHasher());
Review comment:
Does this mean a custom TestSecureHasher impl? Should it be local to
this test only? All the existing SecureHasher impls appear to perform
approximately the same for this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
