CefBoud commented on a change in pull request #4857:
URL: https://github.com/apache/nifi/pull/4857#discussion_r584942067
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/NiFiPropertiesLoader.java
##########
@@ -241,9 +239,53 @@ public NiFiProperties load(String path) {
*/
public NiFiProperties get() {
if (instance == null) {
- instance = loadDefault();
+ instance = setSensitivePropertiesKey(loadDefault());
Review comment:
if `isKeyGenerationRequired` returns false, `setSensitivePropertiesKey`
will have no effect. Maybe renaming the method to something like
`setSensitivePropertiesKeyIfBlank` or externalizing the `if ` enclosing
`setSensitivePropertiesKey`'s body would provide more readability ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
