[
https://issues.apache.org/jira/browse/MINIFICPP-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1522:
------------------------------------
Description:
*Acceptance Criteria:*
*GIVEN* a MiNiFi instance with a flow configuration describing a ConsumeKafka
processor
*AND* in the configuration the "Max Poll Time" property is set to "6 sec"
*WHEN* the MiNiFi instance starts up
*THEN* It should fail due to property validation
*AND* The logs should contain that the reason for this was a property
validation failure on "Max Poll Time"
*Background:*
Currently it is really hard to find out what issue prevents MiNiFi from
starting up if the configuration contains a property that does not pass its
validation. On a ConsumeKafka processor set up with "Max Poll Time": "6 sec",
these are the only corresponding logs that were produced:
{code}
[2021-03-02 16:35:37.375] [org::apache::nifi::minifi::FlowController] [info]
Instantiating new flow
[2021-03-02 16:35:37.377] [org::apache::nifi::minifi::core::YamlConfiguration]
[error] Invalid yaml configuration file
[2021-03-02 16:35:37.377] [main] [error] Failed to load configuration due to
exception: General Operation: Cannot convert invalid value
{code}
*Proposal:*
We should at least try to log the name of the property that is causing a SPoF
due to validation failure.
was:
*Acceptance Criteria:*
*GIVEN* MiNiFi instance with a flow configuration describing a ConsumeKafka
processor
*AND* in the configuration the "Max Poll Time" property is set to "6 sec"
*WHEN* the MiNiFi instance starts up
*THEN* It should fail due to property validation
*AND* The logs should contain that the reason for this was a property
validation failure on "Max Poll Time"
*Background:*
Currently it is really hard to find out what issue prevents MiNiFi from
starting up if the configuration contains a property that does not pass its
validation. On a ConsumeKafka processor set up with "Max Poll Time": "6 sec",
these are the only corresponding logs that were produced:
{code}
[2021-03-02 16:35:37.375] [org::apache::nifi::minifi::FlowController] [info]
Instantiating new flow
[2021-03-02 16:35:37.377] [org::apache::nifi::minifi::core::YamlConfiguration]
[error] Invalid yaml configuration file
[2021-03-02 16:35:37.377] [main] [error] Failed to load configuration due to
exception: General Operation: Cannot convert invalid value
{code}
*Proposal:*
We should at least try to log the name of the property that is causing a SPoF
due to validation failure.
> Log the name of the corresponding faulty properties on validation failures
> --------------------------------------------------------------------------
>
> Key: MINIFICPP-1522
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1522
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Adam Hunyadi
> Priority: Minor
> Labels: MiNiFi-CPP-Hygiene
> Fix For: 1.0.0
>
>
> *Acceptance Criteria:*
> *GIVEN* a MiNiFi instance with a flow configuration describing a ConsumeKafka
> processor
> *AND* in the configuration the "Max Poll Time" property is set to "6 sec"
> *WHEN* the MiNiFi instance starts up
> *THEN* It should fail due to property validation
> *AND* The logs should contain that the reason for this was a property
> validation failure on "Max Poll Time"
> *Background:*
> Currently it is really hard to find out what issue prevents MiNiFi from
> starting up if the configuration contains a property that does not pass its
> validation. On a ConsumeKafka processor set up with "Max Poll Time": "6 sec",
> these are the only corresponding logs that were produced:
> {code}
> [2021-03-02 16:35:37.375] [org::apache::nifi::minifi::FlowController] [info]
> Instantiating new flow
> [2021-03-02 16:35:37.377]
> [org::apache::nifi::minifi::core::YamlConfiguration] [error] Invalid yaml
> configuration file
> [2021-03-02 16:35:37.377] [main] [error] Failed to load configuration due to
> exception: General Operation: Cannot convert invalid value
> {code}
> *Proposal:*
> We should at least try to log the name of the property that is causing a SPoF
> due to validation failure.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
