joewitt commented on pull request #4858: URL: https://github.com/apache/nifi/pull/4858#issuecomment-796032655
Hello team! Can someone please take a look at https://github.com/apache/nifi/pull/4858? If it is deemed reasonable, we're hoping to have it merged as soon as possible :slightly_smiling_face: (edited) mattyb149 9 days ago It would be nice for the transport properties to add dependsOn so only the necessary properties are defined mattyb149 9 days ago https://nifi.apache.org/docs/nifi-docs/html/developer-guide.html#validating-processor-properties Ofek Lev 9 days ago Thanks! Which property are you referring to? Joe Witt 9 days ago In reviewing this a bit it seems like a significant behavior change. Likely for the better but still it is worth noting/considering. Joe Witt 9 days ago For current users of this datadog service this will for sure change the operation for them. Joe Witt 9 days ago We would need to make that clear in the migration guide Joe Witt 9 days ago I dont yet understand how we set the tags to include things like processor names since we're taking those out of the metric name now as suggested Joe Witt 9 days ago is that covered properly? Ofek Lev 8 days ago Yes we test for the tags. How should we document this change? Ofek Lev 7 days ago just let me know! Joe Witt 5 days ago Just need it made clear in the docs for the component and on the PR. I'd flag this in the migration guidance New Ofek Lev 3 hours ago where should I add a note? or is the PR alright as-is? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
