fgerlits commented on a change in pull request #1025:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1025#discussion_r592156442
##########
File path: libminifi/include/core/ProcessorConfig.h
##########
@@ -35,10 +35,8 @@ namespace core {
#define DEFAULT_SCHEDULING_PERIOD_MILLIS 1000
#define DEFAULT_RUN_DURATION 0
#define DEFAULT_MAX_CONCURRENT_TASKS 1
-#define DEFAULT_PENALIZATION_PERIOD 1
-// Default yield period in second
#define DEFAULT_YIELD_PERIOD_SECONDS 1
-#define DEFAULT_PENALIZATION_PERIOD_SECONDS 30
+constexpr std::chrono::seconds DEFAULT_PENALIZATION_PERIOD{30};
Review comment:
done:
https://github.com/apache/nifi-minifi-cpp/pull/1025/commits/38c9df55ef1f8e4767cb04147273be6c3ba39d8a
and
https://github.com/apache/nifi-minifi-cpp/pull/1025/commits/ca6d778860c3f01e54d1dff64a300600a1108941
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
