fgerlits commented on a change in pull request #1011:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1011#discussion_r596180216



##########
File path: extensions/mqtt/processors/ConsumeMQTT.h
##########
@@ -100,7 +100,7 @@ class ConsumeMQTT : public 
processors::AbstractMQTTProcessor {
   void onTrigger(const std::shared_ptr<core::ProcessContext> &context, const 
std::shared_ptr<core::ProcessSession> &session) override;
   // Initialize, over write by NiFi ConsumeMQTT
   void initialize(void) override;
-  bool enqueueReceiveMQTTMsg(MQTTClient_message *message) override;
+  virtual bool enqueueReceiveMQTTMsg(MQTTClient_message *message);

Review comment:
       this change is backwards; `override` is correct




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to