szaszm commented on a change in pull request #1028:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596199210
##########
File path: libminifi/test/rocksdb-tests/ContentSessionTests.cpp
##########
@@ -56,11 +56,10 @@ const std::shared_ptr<minifi::io::BaseStream>&
operator>>(const std::shared_ptr<
str = "";
uint8_t buffer[4096]{};
while (true) {
- size_t ret = stream->read(buffer, sizeof(buffer));
+ const auto ret = stream->read(buffer, sizeof(buffer));
REQUIRE(ret >= 0);
Review comment:
We need both checks, and the new one is one line below. Maybe I
misunderstood your point?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
