martinzink commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r596767716



##########
File path: libminifi/include/utils/OsUtils.h
##########
@@ -29,8 +29,17 @@ namespace OsUtils {
 /// Resolves a user ID to a username
 extern std::string userIdToUsername(const std::string &uid);
 
-/// Returns memory usage in bytes, including shared memory
-uint64_t getMemoryUsage();
+/// Returns physical memory usage by the current process in bytes
+uint64_t getCurrentProcessPhysicalMemoryUsage();

Review comment:
       I also looked into getting information about virtual memory but its 
meaning is wildly inconsistent between platforms and usually doesn't really 
hold useful information. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to