fgerlits commented on a change in pull request #1028:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596915019
##########
File path: extensions/script/lua/LuaBaseStream.cpp
##########
@@ -52,16 +52,11 @@ std::string LuaBaseStream::read(size_t len) {
// 0 <= n < s.size()."
//
// http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2012/n3337.pdf
- auto read = stream_->read(reinterpret_cast<uint8_t *>(&buffer[0]),
static_cast<int>(len));
- if (read < 0) {
- return nullptr;
- }
-
- if (gsl::narrow<size_t>(read) != len) {
- buffer.resize(gsl::narrow<size_t>(read));
+ const auto read = stream_->read(reinterpret_cast<uint8_t *>(&buffer[0]),
len);
+ if (!io::isError(read) && read != len) {
+ buffer.resize(read);
}
-
- return buffer;
+ return io::isError(read) ? std::string{} : buffer;
Review comment:
Yes, I think returning an empty string at line 42 would be fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
