adenes commented on a change in pull request #4917:
URL: https://github.com/apache/nifi/pull/4917#discussion_r599502388
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##########
@@ -141,14 +142,14 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
}
try {
- blob.upload(in, -1, null, null, operationContext);
+ uploadBlob(blob, operationContext, in);
BlobProperties properties = blob.getProperties();
attributes.put("azure.container", containerName);
attributes.put("azure.primaryUri",
blob.getSnapshotQualifiedUri().toString());
attributes.put("azure.etag", properties.getEtag());
attributes.put("azure.length", String.valueOf(length));
attributes.put("azure.timestamp",
String.valueOf(properties.getLastModified()));
- } catch (StorageException | URISyntaxException e) {
+ } catch (StorageException | URISyntaxException | IOException
e) {
storedException.set(e);
Review comment:
@exceptionfactory, thanks for the comment. I have checked the bigger
context, and although I agree that the `storedException` is not needed here,
but when the original exception gets propagated to the [outer `catch`
block](https://github.com/apache/nifi/blob/c8b7bf9b427b1a2026d03c4d3438a5238da8acd2/nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java#L167)
it's wrapped into a `ProcessException` by the framework.
This means that to get the original exception something like `if (e
instanceof ProcessException && e.getCause() instanceof IOException &&
e.getCause().getCause() != null)...` would be needed.
In my opinion the current logic is cleaner and easier to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
