Github user mans2singh commented on the issue:
https://github.com/apache/nifi/pull/239
@jvwing, @miquillo , @simplesteph - Thanks for your feedback and comments.
I've updated to code with the following:
1. Moved tests to stream package
2. Added displayName and name to properties
3. Changed logging level for successful flow files to debug (to reduce
logging output)
4. Added comments on stream provisioning for integration tests - I used 10
shards
5. Moved creation of runner, setting creds file, and stream name to setup
in IT tests.
Regarding logging for successful message processing - I agree that info
level logging for all events is a bit verbose. In the updated code, I've set
the level to debug so that user may choose to get details as they deem
necessary. IMHO - it's better to give the user complete logs, with the option
to turn it off, rather than a fixed number, which could cause confusion if they
are trying to trace their events. Once, users are satisfied with tracing, they
can turn logging level to info to reduce logs.
Regarding logging for failed flow files - IMHO, if we fix the output size
of flow files in the logs, it might not give the complete picture to the user.
Most of the errors (I believe) will be resolved during configuration and setup
and during runtime, there might be a few errors so there might not be lots of
flow files in the logs.
However, in case the consensus is to reduce the flowfiles to a fixed number
(say 10), in successful or failure cases, let me know and I will work on it. I
was just trying to keep things simple and complete.
Regarding packages and names recommendation - The PutKinesis processor was
in stream package but the tests were not, so I've moved them to stream package.
If the consensus is to rename the put processor to PutKinesisStream, let me
know and I will update it.
Thanks again for your feedback and let me know your thoughts.
Mans
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
