[
https://issues.apache.org/jira/browse/NIFI-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15566512#comment-15566512
]
ASF GitHub Bot commented on NIFI-2872:
--------------------------------------
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/1125
@vegaed thanks for putting this together. I have a few initial suggestions
from a quick scan:
* Please run `mvn clean install -Pcontrib-check` - there are a few issues
with .* imports, unused imports, etc.
* Did you forget to incude an entry for PutCloudWatchMetric processor in
the service definition file org.apache.nifi.processor.Processor?
* For PropertyDescriptors, please provide both `name` (as a data key) and
`displayName` (for UI presentation)
* Why not use REL_SUCCESS and REL_FAILURE inherited from
AbstractAWSProcessor? The descriptions would be less specific, but it appears
to be a standard practice.
> Create PutCloudwatchMetric Processor
> ------------------------------------
>
> Key: NIFI-2872
> URL: https://issues.apache.org/jira/browse/NIFI-2872
> Project: Apache NiFi
> Issue Type: Task
> Components: Core Framework
> Affects Versions: 1.1.0
> Reporter: Edgardo Vega
> Priority: Minor
>
> Create a processor for put metrics into aws cloudwatch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
