adamdebreceni commented on a change in pull request #1032:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1032#discussion_r603132719
##########
File path: libminifi/include/core/state/Value.h
##########
@@ -228,36 +225,36 @@ class IntValue : public Value {
}
protected:
- virtual bool getValue(int &ref) {
+ bool getValue(int &ref) override {
ref = value;
return true;
}
- virtual bool getValue(uint32_t &ref) {
+ bool getValue(uint32_t &ref) override {
if (value < 0)
return false;
ref = value;
return true;
}
- virtual bool getValue(int64_t &ref) {
+ bool getValue(int64_t &ref) override {
ref = value;
return true;
}
- virtual bool getValue(uint64_t &ref) {
+ bool getValue(uint64_t &ref) override {
if (value < 0)
Review comment:
I say we go for it if the refactor is not substantial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
