fgerlits commented on a change in pull request #1004:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1004#discussion_r603386255



##########
File path: .github/workflows/ci.yml
##########
@@ -132,12 +142,13 @@ jobs:
         run: |
           sudo apt-add-repository -y "ppa:ubuntu-toolchain-r/test"
           sudo apt update
-          sudo apt install -y gcc-4.8 g++-4.8 bison flex uuid-dev openssl 
libcurl4-openssl-dev ccache libpython3-dev liblua5.1-0-dev libssh2-1-dev
+          sudo apt install -y gcc-4.8 g++-4.8 bison flex uuid-dev openssl 
libcurl4-openssl-dev ccache libpython3-dev liblua5.1-0-dev libssh2-1-dev 
libsqliteodbc
+          sudo ln -s /usr/lib/x86_64-linux-gnu/odbc/libsqlite3odbc.so 
/usr/lib/x86_64-linux-gnu/libsqlite3odbc.so

Review comment:
       Even if the `libsqliteodbc` package is broken, we want `bootstrap.sh` 
followed by `make` to produce a working binary without any extra steps like 
symlinking.  So I would say we either need to figure out how to get `soci` to 
work without the symlink, or put the `ln -s` command in (a script called from) 
bootstrap.sh.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to