ChrisSamo632 commented on pull request #4822: URL: https://github.com/apache/nifi/pull/4822#issuecomment-809686439
@turcsanyip updated per your suggestions. Note that this includes: - added (optional) Record Reader/Writer (@pvillard31 FYI) - better Thread/Session handling for the use of Kinesis Client Library - reverted to KCL verison 1.13.3 due to [amazon-kinesis-client#796](https://github.com/awslabs/amazon-kinesis-client/issues/796) - removed double-validation of dynamic properties (introduced by NIFI-8266 @mattyb149 FYI in case you see an issue with my change to `AbstractConfigurableComponent`) - change to `AbstractProcessor` to remove the `final` modifier of the `onTrigger` method that takes the `ProcessorSessionFactory` - by default processors extending this class will still need to implement the `onTrigger` method that takes the `ProcessSession`, but can now optionally override the former (this seemed a better option in the end than copying the contents of `AbstractProcessor` into `AbstractAWSProcessor`, but happy for that to be challenged) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
