ottobackwards commented on a change in pull request #1026: URL: https://github.com/apache/nifi-minifi-cpp/pull/1026#discussion_r604252231
########## File path: README.md ########## @@ -591,6 +591,10 @@ We welcome all contributions to Apache MiNiFi. To make development easier, we've the linter for the Google Style guide. Google provides an Eclipse formatter for their style guide. It is located [here](https://github.com/google/styleguide/blob/gh-pages/eclipse-cpp-google-style.xml). New contributions are expected to follow the Google style guide when it is reasonable. + Review comment: The only thing I would think about adding here, that I've had to add myself in my shellchecked systems, is some policy on disabling. "If a shellcheck code is disabled explicitly by a script, that should be commented with an explanation at that point and subject to review." That way it is clear to the reviewer and future people why something is the way it is. This assumes that there will be instances where *some* tolerance is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
