markap14 commented on pull request #4933: URL: https://github.com/apache/nifi/pull/4933#issuecomment-812546886
@mattyb149 I think there are some problems with the LICENSE/NOTICE files for minifi-server-nar and minifi-framework-nar. The ones for minifi-framework-nar have almost nothing in them, but the framework nar has tons of dependencies. On the other hand, the minifi-server-nar LICENSE/NOTICE are huge, but the minifi-server-nar only has a few dependencies. Guessing maybe that was done and then a bunch of dependencies moved around? Need to resolve those. I also noticed that in the minifi-framework-nar, the files are added to src/main/resources whereas everywhere else they are in src/main/resources/META-INF. Also noticed that the copyrights indicate "Copyright 2014-2018 The Apache Software Foundation" so that should be updated to be 2014-2021. And minifi-framework-nar's NOTICE file also shows a notice that applies to Apache NiFi. Don't think that's really necessary at this point, given that this is part of the Apache NiFi codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
