arpadboda commented on a change in pull request #1043:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1043#discussion_r609597141
##########
File path: extensions/http-curl/processors/InvokeHTTP.cpp
##########
@@ -75,7 +75,11 @@ core::Property InvokeHTTP::ReadTimeout(
core::Property InvokeHTTP::DateHeader(
core::PropertyBuilder::createProperty("Include Date
Header")->withDescription("Include an RFC-2616 Date header in the
request.")->isRequired(false)->withDefaultValue<bool>(true)->build());
-core::Property InvokeHTTP::FollowRedirects("Follow Redirects", "Follow HTTP
redirects issued by remote server.", "True");
+core::Property InvokeHTTP::FollowRedirects(
+ core::PropertyBuilder::createProperty("Follow Redirects")
+ ->withDescription("Follow HTTP redirects issued by remote server.")
+ ->withDefaultValue<bool>(true)
Review comment:
Hmm, good question.
My reasoning was not based on Curl's default, but what we did before (which
was based on Curl's default).
As minifi is still 0.xxx version, I tend to agree with you and introduce the
breaking change to align with NiFi in this aspect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
