exceptionfactory commented on a change in pull request #4983:
URL: https://github.com/apache/nifi/pull/4983#discussion_r609989120
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/okhttp/OkHttpReplicationClient.java
##########
@@ -317,6 +318,7 @@ private OkHttpClient createOkHttpClient(final
NiFiProperties properties) {
okHttpClientBuilder.followRedirects(true);
final int connectionPoolSize =
properties.getClusterNodeMaxConcurrentRequests();
okHttpClientBuilder.connectionPool(new
ConnectionPool(connectionPoolSize, 5, TimeUnit.MINUTES));
+ okHttpClientBuilder.eventListener(new
RequestReplicationEventListener());
Review comment:
Instead of introducing the custom RequestReplicationEventListener and
CallEventListener classes for logging, would the
`okhttp3.logging.LoggingEventListener` class accomplish the same goal?
Introducing the potential for logging events could have performance
implications, what do you think about adding check for
`logger.isDebugEnabled()` to control whether or not to add the Event Listener?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
