gresockj opened a new pull request #4991:
URL: https://github.com/apache/nifi/pull/4991
#### Description of PR
This enables auto-refreshing of the keystore and truststore configured in
nifi.properties using Jetty's SSLContextFactory.reload(...) method. This
functionality is disabled by default, but can be configured using the following
new properties in nifi.properties:
nifi.security.autorefresh.enabled=true
nifi.security.autorefresh.interval=10 secs
If enabled, the keystore and truststore files will be monitored at the
refresh interval specified. If any changes are detected in either one, a
refresh of the SSLContextFactory is attempted, which essentially allows trusted
certificates to be added to the trust store on the fly, or certificates to be
updated in the keystore for expiration purposes.
If a reload is to be attempted, the code first performs a security check by
verifying that there are no new aliases in the keystore, that the subject and
issuer DN have not changed in the keystore, and if the issuer cert was provided
in the certificate chain, that its serial number is the same as upon startup.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
