jfrazee commented on a change in pull request #4576:
URL: https://github.com/apache/nifi/pull/4576#discussion_r611899602
##########
File path:
nifi-nar-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/storage/FetchGCSObject.java
##########
@@ -233,8 +233,15 @@ public void onTrigger(ProcessContext context,
ProcessSession session) throws Pro
throw new StorageException(404, "Blob " + blobId + " not
found");
}
+ if (rangeStart > 0 && rangeStart >= blob.getSize()) {
+ getLogger().debug("Start position: {}, blob size: {}", new
Object[] {rangeStart, blob.getSize()});
Review comment:
Minor thing, in general we try to wrap the debugs in an
`isDebugEnabled()`. This one should (hopefully) be reached only very rarely so
definitely not a big deal, but thought I'd mention it for the future.
```suggestion
if (getLogger().isDebugEnabled() {
getLogger().debug("Start position: {}, blob size: {}",
new Object[] {rangeStart, blob.getSize()});
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
