[ 
https://issues.apache.org/jira/browse/NIFI-8421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17322041#comment-17322041
 ] 

Simon Bence commented on NIFI-8421:
-----------------------------------

Thanks for the amendment! I am really not fond of burnt in waiting times in 
test, but as the real persisting happens independently, I could not rely on a 
hook-point. An other refinement we might do is to add "intelligent" waiting, 
which after an initial waiting time, tries to poll a number of times. 
[https://www.baeldung.com/awaitlity-testing] This would ensure that in normal 
conditions the test would not run for long but also would prevent it from being 
flaky. What do you think?

> EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest relies on arbitrary 
> timeout leading to brittle test runs
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-8421
>                 URL: https://issues.apache.org/jira/browse/NIFI-8421
>             Project: Apache NiFi
>          Issue Type: Task
>          Components: Core Framework
>            Reporter: Joe Witt
>            Assignee: Simon Bence
>            Priority: Major
>
> Error:  Failures: 
> Error:    
> EmbeddedQuestDbStatusHistoryRepositoryForComponentsTest.testWritingThenReadingComponents:46->assertCorrectStatusHistory:106
>  expected:<1> but was:<0>
> Error:  Tests run: 394, Failures: 1, Errors: 0, Skipped: 7
> Error:  Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on 
> project nifi-framework-core: There are test failures.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to