greyp9 commented on a change in pull request #5008:
URL: https://github.com/apache/nifi/pull/5008#discussion_r616950489
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
##########
@@ -1012,6 +1012,30 @@ protected static void
configureSslContextFactory(SslContextFactory.Server contex
contextFactory.setIncludeProtocols(TlsConfiguration.getCurrentSupportedTlsProtocolVersions());
contextFactory.setExcludeProtocols("TLS", "TLSv1", "TLSv1.1", "SSL",
"SSLv2", "SSLv2Hello", "SSLv3");
+ // on configuration, replace default application cipher suites with
those configured
+ final String includeCipherSuitesProps =
props.getProperty(NiFiProperties.WEB_HTTPS_INCLUDE_CIPHERSUITES);
+ if (!StringUtils.isEmpty(includeCipherSuitesProps)) {
+ logger.info(String.format("NiFiProperties.%s = %s",
+ NiFiProperties.WEB_HTTPS_INCLUDE_CIPHERSUITES,
includeCipherSuitesProps));
Review comment:
^c^v
I wanted to cover our bases in case of failure of the String -> String[] ->
String transform....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
