fgerlits commented on a change in pull request #1040:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1040#discussion_r617341668
##########
File path: docker/test/integration/features/hashcontent.feature
##########
@@ -0,0 +1,10 @@
+Feature: Adding hash value for a FlowFile using HashContent
+ In order to calculate a hash value for a FlowFile
+ As a user of MiNiFi
+ I need to have HashContent Processor
+
+Background:
+ Given the content of "/tmp/output" is monitored
+
+Scenario: HashContent adds hash attribute to flowfiles
+ Given a GetFile processor with "Input Directory" property set to
"/tmp/input"
Review comment:
this file was included in this PR by accident, I think
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -75,13 +75,10 @@ struct string_traits<wchar_t>{
class StringUtils {
public:
/**
- * Converts a string to a boolean
- * Better handles mixed case.
+ * Checks and converts a string to a boolean
* @param input input string
- * @param output output string.
+ * @returns an optional of a boolean: true if the string is "true" (ignoring
case), false if it is "false" (ignoring case), nullopt for any other value
*/
- static bool StringToBool(std::string input, bool &output);
Review comment:
This is good, but `StringToBool()` is still there in the cpp file, and
it is also called from one place. Type `git grep StringToBool` to find all
usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
