exceptionfactory commented on pull request #5015: URL: https://github.com/apache/nifi/pull/5015#issuecomment-824181474
> The KeystoreUtils changes look good, I'm just curious about the unit test refactoring. Can you expand on your reasoning for the refactoring there? For example, I'm wondering why testKeyStoreRoundTrip is no longer being used, etc. Thanks for the feedback @gresockj. The core concept of the round trip methods remains, but I removed the unnecessary KeyStoreSupplier interface and streamlined the methods. The `assertKeyEntryStoredLoaded` and `assertCertificateEntryStoredLoaded` methods follow the same approach as before by populating a source KeyStore with an entry, writing it to an OutputStream, and then reading it into a destination KeyStore instance. I wrapped all of in a loop that tests all values in the `KeystoreType` enum. Previously there were individual test methods for each KeystoreType, so this approach ensures that any changes to `KeystoreType` will automatically be tested. Let me know if you have any other questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
