exceptionfactory commented on a change in pull request #5016:
URL: https://github.com/apache/nifi/pull/5016#discussion_r617729422



##########
File path: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -857,6 +859,9 @@ public void onTrigger(ProcessContext context, 
ProcessSession session) throws Pro
                 statusAttributes.put(STATUS_MESSAGE, statusMessage);
                 statusAttributes.put(REQUEST_URL, url.toExternalForm());
                 statusAttributes.put(TRANSACTION_ID, txId.toString());
+                if(context.getProperty(PROP_FOLLOW_REDIRECTS).asBoolean()) {

Review comment:
       Thanks for the response and updates @pkelly-nifi, the changes look good. 
 Could you also update the InvokeHTTPTest to check for the existence of the 
Response URL attribute?  The `assertStatusCodeEquals()` method has a check for 
the InvokeHTTP.REQUEST_URL attribute, so just adding a line to check for the 
Response URL attribute should be sufficient.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to