greyp9 commented on a change in pull request #5018:
URL: https://github.com/apache/nifi/pull/5018#discussion_r617924217
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
##########
@@ -1012,6 +1016,28 @@ protected static void
configureSslContextFactory(SslContextFactory.Server contex
contextFactory.setIncludeProtocols(TlsConfiguration.getCurrentSupportedTlsProtocolVersions());
contextFactory.setExcludeProtocols("TLS", "TLSv1", "TLSv1.1", "SSL",
"SSLv2", "SSLv2Hello", "SSLv3");
+ // on configuration, replace default application cipher suites with
those configured
+ final String includeCipherSuitesProps =
props.getProperty(NiFiProperties.WEB_HTTPS_CIPHERSUITES_INCLUDE);
+ if (StringUtils.isNotEmpty(includeCipherSuitesProps)) {
+ final String[] includeCipherSuitesRuntime =
contextFactory.getIncludeCipherSuites();
+ final String[] includeCipherSuites =
includeCipherSuitesProps.split(REGEX_SPLIT_PROPERTY);
+ logger.info("Replacing include cipher suites with configuration;
runtime = {}, raw property = {}, parsed property = {}.",
Review comment:
I'm worried about edge cases, but may be overly cautious. Will change
to logging just the parsed value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
