[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build

[GitBox]

adamdebreceni commented on a change in pull request #1055:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1055#discussion_r618334196



##########
File path: cmake/DockerConfig.cmake
##########
@@ -22,7 +22,6 @@ add_custom_target(
         -u 1000
         -g 1000
         -v 
${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}.${PROJECT_VERSION_PATCH}
-        -c IMAGE_TYPE=release

Review comment:
       should we use `-i release` here as well (other targets use it like 
that)? or should we remove `-i, -u, -g` wherever they align with the defaults 
in `DockerBuild.sh`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org