exceptionfactory commented on a change in pull request #5020:
URL: https://github.com/apache/nifi/pull/5020#discussion_r618628897
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKuduProcessor.java
##########
@@ -184,10 +200,25 @@ protected KuduClient buildClient(final ProcessContext
context) {
final String masters =
context.getProperty(KUDU_MASTERS).evaluateAttributeExpressions().getValue();
final int operationTimeout =
context.getProperty(KUDU_OPERATION_TIMEOUT_MS).evaluateAttributeExpressions().asTimePeriod(TimeUnit.MILLISECONDS).intValue();
final int adminOperationTimeout =
context.getProperty(KUDU_KEEP_ALIVE_PERIOD_TIMEOUT_MS).evaluateAttributeExpressions().asTimePeriod(TimeUnit.MILLISECONDS).intValue();
+ final int workerCount = context.getProperty(WORKER_COUNT).asInteger();
+
+ // Create Executor following approach of
Executors.newCachedThreadPool() using worker count as maximum pool size
+ final int corePoolSize = 0;
+ final long threadKeepAliveTime = 60;
+ final Executor nioExecutor = new ThreadPoolExecutor(
+ corePoolSize,
+ workerCount,
+ threadKeepAliveTime,
+ TimeUnit.SECONDS,
+ new SynchronousQueue<>(),
+ new ClientThreadFactory(getIdentifier())
+ );
return new KuduClient.KuduClientBuilder(masters)
.defaultOperationTimeoutMs(operationTimeout)
- .defaultSocketReadTimeoutMs(adminOperationTimeout)
+ .defaultAdminOperationTimeoutMs(adminOperationTimeout)
Review comment:
Reverted the change for now, something that can be addressed separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
