Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1127#discussion_r83218107
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ControlRate.java
 ---
    @@ -381,6 +392,14 @@ public boolean tryAdd(final long value) {
     
         private class ThrottleFilter implements FlowFileFilter {
     
    +        private final long flowFilesPerTrigger;
    +        private final AtomicLong flowFilesFiltered = new AtomicLong(0L);
    --- End diff --
    
    This filter is not thread-safe... don't think we need an AtomicLong here. 
Can just use an int.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to