[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1059: MINIFICPP-1510 Register and fix InvokeHTTPTests

[GitBox]

lordgamez commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r620055279



##########
File path: extensions/http-curl/tests/unit/InvokeHTTPTests.cpp
##########
@@ -270,19 +276,21 @@ TEST_CASE("HTTPTestsWithResourceClaimPOST", 
"[httptest1]") {
     REQUIRE(provEventRecord->getComponentType() == listenhttp->getName());
   }
   std::shared_ptr<core::FlowFile> ffr = session2->get();
-  REQUIRE(true == LogTestController::getInstance().contains("exiting because 
method is POST"));
+  REQUIRE(true == LogTestController::getInstance().contains("Exiting because 
method is POST"));
   LogTestController::getInstance().reset();
 }
 
 TEST_CASE("HTTPTestsPostNoResourceClaim", "[httptest1]") {
   TestController testController;
-  
LogTestController::getInstance().setInfo<org::apache::nifi::minifi::processors::InvokeHTTP>();
-  
LogTestController::getInstance().setInfo<org::apache::nifi::minifi::processors::ListenHTTP>();
+  
LogTestController::getInstance().setDebug<org::apache::nifi::minifi::processors::ListenHTTP>();

Review comment:
       In the test we are checking for "Exiting because method is POST" log 
message which is a debug log, so we have to modify the log level to be able to 
assert on that. It was probably an info level log previously and changed later.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org