jfrazee commented on a change in pull request #5004:
URL: https://github.com/apache/nifi/pull/5004#discussion_r621720876
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/AbstractHeartbeatMonitor.java
##########
@@ -343,4 +374,25 @@ public void onLocalNodeIdentifierSet(final NodeIdentifier
localNodeId) {
public void onNodeStateChange(final NodeIdentifier nodeId, final
NodeConnectionState newState) {
}
}
+
+ private class RemoveHeartbeatsOnNodeRemoval implements
ClusterTopologyEventListener {
Review comment:
@markap14 I'm confused about the difference between
`RemoveHeartbeatsOnNodeRemoval` and `ClusterChangeEventListener` which both
seem to just remove heartbeats for `onNodeRemoved()`. Is there a reason to not
register/unregister `ClusterChangeEventListener` on `start()` and `stop()` and
just have one of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
