fgerlits commented on a change in pull request #1063:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1063#discussion_r621967842
##########
File path: extensions/windows-event-log/wel/WindowsEventLog.cpp
##########
@@ -105,7 +105,6 @@ void WindowsEventLogMetadataImpl::renderMetadata() {
default:
event_type_index_ = 0;
};
Review comment:
not related to blank lines, but this `;` is not needed here and will
cause a linter error at some point
##########
File path: extensions/mqtt/protocol/MQTTC2Protocol.h
##########
@@ -86,7 +86,6 @@ class MQTTC2Protocol : public C2Protocol {
// mqtt controller serviec name.
std::string controller_service_name_;
-
Review comment:
both blank lines could be removed here
##########
File path: extensions/rocksdb-repos/DatabaseContentRepository.h
##########
@@ -64,7 +64,6 @@ class StringAppender : public
rocksdb::AssociativeMergeOperator {
}
private:
-
Review comment:
the previous two lines could be removed, too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
