tpalfy commented on a change in pull request #4516:
URL: https://github.com/apache/nifi/pull/4516#discussion_r622137775
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
##########
@@ -829,6 +833,105 @@ public Response updateRemoteProcessGroupRunStatus(
);
}
+ /**
+ * Updates the operational status for all remote process groups in the
specified process group with the specified value.
+ *
+ * @param httpServletRequest request
+ * @param processGroupId The id of the process group in
which all remote process groups to update.
+ * @param requestRemotePortRunStatusEntity A remotePortRunStatusEntity
that holds the desired run status
+ * @return A response with an array of RemoteProcessGroupEntity objects.
+ */
+ @PUT
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("process-group/run-status/{id}")
Review comment:
The `RemoteProcessGroup` is significantly different from `Connectables`
(handled by the `/flow/process-groups/{id}` endpoint) and the
`ControllerServices` (handled by the
`/flow/process-groups/{id}/remote-process-groups`) endpoint.
The most prominent manifestation of this is how the merging of the request
fits perfectly into the `RemoteProcessGroupsEndpointMerger` and not at all into
the `FlowMerger`.
There are other signs that this functionality is more suited to handled
here, like private methods in this class that would be needed to be accessed
from the `FlowResource`.
Leaving it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
