turcsanyip commented on a change in pull request #4516:
URL: https://github.com/apache/nifi/pull/4516#discussion_r622204815
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/RemoteProcessGroupResource.java
##########
@@ -829,6 +833,105 @@ public Response updateRemoteProcessGroupRunStatus(
);
}
+ /**
+ * Updates the operational status for all remote process groups in the
specified process group with the specified value.
+ *
+ * @param httpServletRequest request
+ * @param processGroupId The id of the process group in
which all remote process groups to update.
+ * @param requestRemotePortRunStatusEntity A remotePortRunStatusEntity
that holds the desired run status
+ * @return A response with an array of RemoteProcessGroupEntity objects.
+ */
+ @PUT
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("process-group/run-status/{id}")
Review comment:
@tpalfy I can see the problematic points now (eg. private methods) and
leaving the endpoint in RemoteProcessGroup is fine with me.
Regarding the path, I would suggest a minor change:
`/remote-process-groups/process-group/{id}/run-status`
In case of other endpoints, the {id} follows the entity it identifies (in
our case it is a process group id). So I believe it would be more
straightforward in this way and also similar to the single RPG start/stop
endpoint: `/remote-process-groups/{id}/run-status`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
