szaszm commented on a change in pull request #1052:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r622184549
##########
File path: extensions/standard-processors/processors/TailFile.h
##########
@@ -179,6 +212,8 @@ class TailFile : public core::Processor {
std::shared_ptr<core::FlowFile> &flow_file)
const;
void updateStateAttributes(TailState &state, uint64_t size, uint64_t
checksum) const;
+
+ bool isOldFileInitiallyRead(TailState &state) const;
Review comment:
Could you move the member function declarations above the data member
declarations? Things are all over the place now and it's getting hard to follow.
##########
File path: extensions/standard-processors/processors/TailFile.h
##########
@@ -147,13 +166,27 @@ class TailFile : public core::Processor {
std::string rolling_filename_pattern_;
+ InitialStartPositions initial_start_position_;
+
+ bool first_trigger_{true};
Review comment:
This member can be accessed and modified concurrently without
synchronization by two concurrent onTriggers. The state management seems to
have the same issue, but it's not coming from this PR. Other data members seem
to come from properties in onSchedule, those should be fine without
synchronization, as onSchedule cannot run concurrently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
