jfrazee commented on pull request #5034:
URL: https://github.com/apache/nifi/pull/5034#issuecomment-831583976


   @gresockj I have a high level question about the interfaces. Is there 
anything we can pull up a level? `VaultCommunicationService`, `VaultProperty`, 
and `VaultProperties` mostly look like things that could cut across different 
vault implementations and might deserve to be in an api module?
   
   Or is the plan that this will be used internally by another more generic set 
of classes when bringing them into the SPPs, etc. and it's irrelevant what's 
going on here?
   
   (There are several related JIRAs going on so apologies if this has already 
been clarified.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to