exceptionfactory commented on a change in pull request #5044: URL: https://github.com/apache/nifi/pull/5044#discussion_r632532916
########## File path: nifi-nar-bundles/nifi-extension-utils/nifi-event-transport/src/main/java/org/apache/nifi/event/transport/netty/EventLoopGroupFactory.java ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.event.transport.netty; + +import io.netty.channel.EventLoopGroup; +import io.netty.channel.nio.NioEventLoopGroup; +import io.netty.util.concurrent.DefaultThreadFactory; + +import java.util.Objects; +import java.util.concurrent.ThreadFactory; + +/** + * Event Loop Group Factory for standardized instance creation + */ +class EventLoopGroupFactory { + private static final String DEFAULT_THREAD_NAME_PREFIX = "NettyEventLoopGroup"; + + private static final boolean DAEMON_THREAD_ENABLED = true; + + private String threadNamePrefix = DEFAULT_THREAD_NAME_PREFIX; + + private int workerThreads; + + /** + * Set Thread Name Prefix used in Netty NioEventLoopGroup defaults to NettyChannel + * + * @param threadNamePrefix Thread Name Prefix + */ + public void setThreadNamePrefix(final String threadNamePrefix) { + this.threadNamePrefix = Objects.requireNonNull(threadNamePrefix, "Thread Name Prefix required"); + } + + /** + * Set Worker Threads used in Netty NioEventLoopGroup with 0 interpreted as the default based on available processors + * + * @param workerThreads NioEventLoopGroup Worker Threads + */ + public void setWorkerThreads(final int workerThreads) { + this.workerThreads = workerThreads; + } + + EventLoopGroup getEventLoopGroup() { Review comment: Good question, I originally intended for this base class and the inheriting subclasses to be scoped as narrowly as possible so that implementations would remain in this package. Changing this to protected would maintain that intent while allowing a bit more flexibility, so will change to protected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
